Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update NFD version to v0.15.6 #981

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

adrianchiris
Copy link
Collaborator

No description provided.

@adrianchiris adrianchiris changed the title Update NFD version to v0.15.4 chore: Update NFD version to v0.15.4 Jun 27, 2024
@adrianchiris adrianchiris requested a review from e0ne June 27, 2024 14:49
@coveralls
Copy link
Collaborator

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9698749749

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 29 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.5%) to 62.9%

Files with Coverage Reduction New Missed Lines %
pkg/state/state_hostdevice_network.go 2 78.38%
pkg/state/state_skel.go 2 83.04%
api/v1alpha1/zz_generated.deepcopy.go 4 37.63%
controllers/hostdevicenetwork_controller.go 21 68.18%
Totals Coverage Status
Change from base Build 9687201354: -0.5%
Covered Lines: 3201
Relevant Lines: 5089

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9699885488

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 63.568%

Files with Coverage Reduction New Missed Lines %
controllers/macvlannetwork_controller.go 2 86.25%
Totals Coverage Status
Change from base Build 9687201354: 0.2%
Covered Lines: 3235
Relevant Lines: 5089

💛 - Coveralls

@adrianchiris
Copy link
Collaborator Author

/retest-nic_operator_helm

@coveralls
Copy link
Collaborator

coveralls commented Jul 1, 2024

Pull Request Test Coverage Report for Build 9742833080

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 30 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.4%) to 63.293%

Files with Coverage Reduction New Missed Lines %
pkg/state/state_hostdevice_network.go 2 78.38%
controllers/nicclusterpolicy_controller.go 2 79.5%
pkg/state/state_skel.go 2 84.82%
api/v1alpha1/zz_generated.deepcopy.go 4 37.63%
controllers/ipoibnetwork_controller.go 5 77.38%
controllers/hostdevicenetwork_controller.go 15 75.0%
Totals Coverage Status
Change from base Build 9739691930: -0.4%
Covered Lines: 3221
Relevant Lines: 5089

💛 - Coveralls

@adrianchiris
Copy link
Collaborator Author

/retest-all

@adrianchiris
Copy link
Collaborator Author

we should hold with this until issue[1] is resolved, then update to a version that contains the fix.

[1] kubernetes-sigs/node-feature-discovery#1752

@adrianchiris adrianchiris changed the title chore: Update NFD version to v0.15.4 [DNM] chore: Update NFD version to v0.15.4 Jul 1, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9760067150

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 63.568%

Files with Coverage Reduction New Missed Lines %
pkg/state/state_skel.go 4 83.63%
controllers/nicclusterpolicy_controller.go 9 75.31%
Totals Coverage Status
Change from base Build 9739691930: -0.1%
Covered Lines: 3235
Relevant Lines: 5089

💛 - Coveralls

Signed-off-by: adrianc <adrianc@nvidia.com>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9894349534

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 63.608%

Files with Coverage Reduction New Missed Lines %
controllers/nicclusterpolicy_controller.go 1 79.08%
controllers/macvlannetwork_controller.go 2 86.25%
pkg/state/state_ipoib_network.go 4 75.24%
controllers/ipoibnetwork_controller.go 7 77.38%
Totals Coverage Status
Change from base Build 9891179419: 0.0%
Covered Lines: 3237
Relevant Lines: 5089

💛 - Coveralls

@adrianchiris adrianchiris changed the title [DNM] chore: Update NFD version to v0.15.4 chore: Update NFD version to v0.15.6 Jul 11, 2024
@adrianchiris
Copy link
Collaborator Author

@e0ne this one is ready for review.

@adrianchiris
Copy link
Collaborator Author

/retest-nic_operator_helm

@adrianchiris
Copy link
Collaborator Author

helm CI fails for the folllowing reason:

fatal: [localhost]: FAILED! => {"changed": false, "command": "/usr/local/bin/helm upgrade -i --reset-values --wait --create-namespace --values=/tmp/k8s_1872430/artifacts/device-id-helm-values.yaml network-operator-helm-ci /tmp/k8s_1872430/mellanox-network-operator/deployment/network-operator", "msg": "Failure when executing Helm command. Exited 1.\nstdout: \nstderr: WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /etc/kubernetes/admin.conf\nWARNING: Kubernetes configuration file is world-readable. This is insecure. Location: /etc/kubernetes/admin.conf\nError: UPGRADE FAILED: failed to create patch: unable to find api field in struct Probe for the json field \"grpc\"\n", "stderr": "WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /etc/kubernetes/admin.conf\nWARNING: Kubernetes configuration file is world-readable. This is insecure. Location: /etc/kubernetes/admin.conf\nError: UPGRADE FAILED: failed to create patch: unable to find api field in struct Probe for the json field \"grpc\"\n", "stderr_lines": ["WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /etc/kubernetes/admin.conf", "WARNING: Kubernetes configuration file is world-readable. This is insecure. Location: /etc/kubernetes/admin.conf", "Error: UPGRADE FAILED: failed to create patch: unable to find api field in struct Probe for the json field \"grpc\""], "stdout": "", "stdout_lines": []}

our CI is using K8s 1.21.3 however grpc liveness/readiness probes were introduced in 1.23
kubernetes officially supports 1.27 as the oldest version.

@adrianchiris
Copy link
Collaborator Author

/retest-nic_operator_helm

1 similar comment
@adrianchiris
Copy link
Collaborator Author

/retest-nic_operator_helm

@adrianchiris
Copy link
Collaborator Author

@e0ne updated helm on ci machine for nic-operator-helm-ci we can merge this one now IMO.

@adrianchiris adrianchiris merged commit 9cb4144 into Mellanox:master Jul 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants